Design tokens for CTA #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazingrando
requested changes
Mar 26, 2024
There was a problem hiding this comment.
@mariannuar This is looking good and almost there. I've recorded a short video describing my feedback at https://www.loom.com/share/2038980a14014b36aba1d13ad9b692a1?sid=87f4208f-cc52-4038-a202-1c59f09ad676
- Give the top CTA in the Figma file a background (white or transparent) to make swapping the different CTA types easier.
- Have the color tokens reference tokens in the "semantic" section instead of directly choosing the colors from the "global" space.
amazingrando
added
👉 Needs Work
mariannuar
added
👍 Ready for Review
|
@amazingrando Ready for review again! Thanks! |
amazingrando
added
🎉 Passes Functional Review
amazingrando
added
🎉 Passes Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves design tokens for EMULSIF-71
How to review this pull request
To review, confirm that CTA component exists and has design tokens in the Emulsify UI Kit.