Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: node 20, mv components directory src to root, add emulsify-cor… #117

Merged
merged 97 commits into from
Sep 10, 2024

Conversation

joetower
Copy link

@joetower joetower commented Mar 22, 2024

…e as only dependency

Summary

This PR fixes/implements the following bugs/features

  • Upgrades the .nvmrc file to node 20
  • Includes emulsify-core as the only dependency - aside from ui-kit-specific dev dependencies
  • Makes the sass structure modular, using @use and @forward instead of @import
  • Moves components directory to the root from src/components - the cli expects components to live in the root
  • Updates images directory name to assets

Explain the motivation for making this change. What existing problem does the pull request solve?

Documentation update (required)

If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.

How to review this pull request

  • Checkout branch
  • Remove your node_modules directory - rm -rf node_modules
  • Run npm install
  • Run npm run develop and make sure Storybook runs properly
  • Cancel and run npm run build and make sure everything builds as it should

Closing issues

Closes #

@joetower joetower added the 🚧 Work in Progress The PR is a work in progress. label Mar 22, 2024
@joetower joetower self-assigned this Mar 22, 2024
joetower and others added 27 commits March 22, 2024 22:16
…m:emulsify-ds/emulsify-ui-kit into emulsif-236-convert-images-to-support-sdc
…m:emulsify-ds/emulsify-ui-kit into emulsif-241-convert-pager-to-support-sdc
Callin Mullaney and others added 22 commits August 27, 2024 15:36
…o-support-sdc

EMULSIF-236: Convert Images to support SDC
…-support-sdc

EMULSIF-241: Convert Pager to support SDC
…o-support-sdc

EMULSIF-242: Convert Status to support SDC
…o-support-sdc

EMULSIF-243: Convert Tables to support SDC
…support-sdc

EMULSIF-244: Convert Tabs to support SDC
…support-sdc

EMULSIF-245: Convert Text to support SDC
…o-support-sdc

EMULSIF-246: Convert Videos to support SDC
@callinmullaney callinmullaney added 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 🚧 Work in Progress The PR is a work in progress. labels Sep 9, 2024
@callinmullaney callinmullaney merged commit da3f4f5 into convert-components-to-sdc Sep 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants