Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli-compat): allow install from emulsify-cli with default components #115

Merged
merged 6 commits into from
Mar 1, 2024
Merged

feat(cli-compat): allow install from emulsify-cli with default components #115

merged 6 commits into from
Mar 1, 2024

Conversation

mikeethedude
Copy link
Contributor

@mikeethedude mikeethedude commented Mar 1, 2024 •
edited by amazingrando
Loading

Summary

This adds some default components so that UI Kit can be installed by emulsify cli.

Related to emulsify-ds/emulsify-cli#233

This allows for this to be installed without major architectural changes to Emulsify CLI

How to review this pull request

  • Install emulsify like normal `emulsify init "something" --platform drupal <path/to/drupal>
  • Go to the installed theme and check out this branch `emulsify system install --repository https://github.com/emulsify-ds/emulsify-ui-kit.git --checkout update-system-config
  • Should have installed with a few default components. Successfully installed the emulsify-ui-kit system using the drupal variant.

@mikeethedude mikeethedude marked this pull request as ready for review March 1, 2024 19:55
@mikeethedude mikeethedude mentioned this pull request Mar 1, 2024
Closed
@amazingrando amazingrando self-assigned this Mar 1, 2024
@amazingrando amazingrando added the 🎉 Passes Functional Review Functionality is approved by the reviewer. label Mar 1, 2024
@amazingrando amazingrando added 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. labels Mar 1, 2024
@amazingrando amazingrando merged commit dd16c60 into main Mar 1, 2024
1 of 2 checks passed
@amazingrando amazingrando deleted the update-system-config branch March 1, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingrando amazingrando amazingrando approved these changes

@callinmullaney callinmullaney Awaiting requested review from callinmullaney

@mariannuar mariannuar Awaiting requested review from mariannuar

@josue2591 josue2591 Awaiting requested review from josue2591

@robherba robherba Awaiting requested review from robherba

Assignees

@amazingrando amazingrando

Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer.
Projects
Emulsify Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeethedude @amazingrando