Pager styled with design tokens #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariannuar
changed the title
…-ds/emulsify-ui-kit into pager-styled-with-design-tokens
amazingrando
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
@mariannuar I have a couple of questions that I am curious about. This code is approved. 
| * @see template_preprocess_pager() | ||
| */ | ||
| #} | ||
| {% set pager__base_class = 'pager' %} |
There was a problem hiding this comment.
What do you think about making this pager__base_class = pager__base_class|default('pager') to make it easy to override the base class?
| {% if items.previous %} | ||
| <li {{ bem('item', ['prev'], pager__base_class) }}> | ||
| <a {{ bem('link', ['prev'], pager__base_class) }} href="{{ items.previous.href }}" title="{{ 'Go to previous page'|t }}" rel="prev"{{ items.previous.attributes|without('href', 'title', 'rel') }}> | ||
| <span {{ bem('visually-hidden') }}>{{ 'Previous page'|t }}</span> |
There was a problem hiding this comment.
If we are only adding a single class, should the span be <span class="visually-hidden"> without the bem function? No need to change it. I'm just curious about the answer to the question.
There was a problem hiding this comment.
@amazingrando Oh! I just copy-paste what it was already of the compound components. That's why it's like that, but you're right
amazingrando
added
🎉 Passes Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR styled the Pager component with design tokens
How to review this pull request
npm run developCloses #96