Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI Kit to systems #286

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Add UI Kit to systems #286

merged 2 commits into from
Aug 30, 2024

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Aug 30, 2024

Summary

Adds Emulsify UI Kit as an allowed system to install via the CLI

This PR fixes/implements the following bugs/features

  • Adds Emulsify UI Kit as an allowed system to install via the CLI

The Emulsify UI Kit is almost ready for production and this grants the CLI the ability to quickly install it instead of just the original system, compound

Documentation update (required)

To install the new Emulsify UI Kit into an existing Emulsify-based project, run the following command from within the root of your custom Emulsify theme directory:

emulsify system install emulsify-ui-kit

How to review this pull request

  • Clone this repo locally
  • Go into the directory and change to this branch git checkout add-ui-kit
  • Run npm install
  • Run npm run build
  • Run npm link
  • Run which emulsify
  • Go to the directory where Emulsify is currently installed on your local system - I.e. to the place where there is a symlink to emulsify. Something like this when you run ls -la:
lrwxr-xr-x  1 user  staff    47B Aug 29 22:06 emulsify -> ../lib/node_modules/@emulsify/cli/dist/index.js
  • Run npm link path-to-cloned-repo/emulsify-cli
  • Create an Emulsify theme (With the new 5.0 version, you can run drush emulsify my-theme-name from the root of the Drupal project to create a custom Emulsify theme
  • From within the root of that newly created theme, run emulsify system install emulsify-ui-kit
  • Verify that a new src directory is created in your custom theme and that it contains some components from the UI kit
  • To revert your copy of emulsify, I haven't found a good way using npm unlink so, I simply deleted ../lib/node_modules/@emulsify and the symlink in ~/.nvm/versions/node/v20.17.0/bin entirely and re-ran npm install -g @emulsify/cli

@codechefmarc codechefmarc self-assigned this Aug 30, 2024
@codechefmarc codechefmarc added the 👍 Ready for Review Work is ready for review. label Aug 30, 2024
Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc Thank you for adding this to the CLI and the thorough testing steps. I ran through them and was able install the UI Kit. 🎉

I'll get this merged and released.

@callinmullaney callinmullaney added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Aug 30, 2024
@callinmullaney callinmullaney merged commit 06d04e5 into develop Aug 30, 2024
2 of 3 checks passed
Copy link

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants