-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(93): replacing placeimg with Picsum #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mndonx! This looks great, I can confirm that the replacement was successful
I might wanna wait on this to see if we should standardize on a service project-wide. |
@Yuvania I ended up changing this from LoremFlickr to Picsum. I think that may be what we standardize on cross-projects. I also added something to imgsrcsets to make sure it was always pulling the same image (using an ID in the URL) so it didn't swap images when you cross breakpoints. Let me know if it still looks good to you! Thank you!! |
Can confirm that the placeholder images are now all using Picsum. Looks good! |
🎉 This PR is included in version 1.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
How to review this pull request
Closing issues
Closes #93