Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(101): storybook deploy error - 2 #103

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix(101): storybook deploy error - 2 #103

merged 2 commits into from
Nov 2, 2023

Conversation

mcortes19
Copy link
Collaborator

@mcortes19 mcortes19 commented Nov 2, 2023 •
edited
Loading

Summary

This PR fixes storybook deploy GH action

How to review this pull request

  • There's no way to perform a functional testing to this Github Action until it gets merged
  • Take a look at code to make sure changes make sense.

Closing issues

Closes #101

@mcortes19 mcortes19 added 🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. labels Nov 2, 2023
@mcortes19 mcortes19 self-assigned this Nov 2, 2023
@mcortes19 mcortes19 changed the title fix: add build command to pre-build required assets fix(101): storybook deploy error - 2 Nov 2, 2023
@mcortes19 mcortes19 marked this pull request as draft November 2, 2023 21:56
@mcortes19 mcortes19 marked this pull request as ready for review November 2, 2023 21:57
mariannuar
mariannuar approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mariannuar mariannuar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mcortes19 mcortes19 merged commit 91618f7 into main Nov 2, 2023
2 checks passed
@mcortes19 mcortes19 deleted the compound-101-storybook-deploy-issue branch November 2, 2023 22:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

🎉 This PR is included in version 1.17.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariannuar mariannuar mariannuar approved these changes

Assignees

@mcortes19 mcortes19

Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Ready to Merge Functionality is approved by the reviewer. released
Projects
Emulsify Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Deploy Storybook to Github Pages error
2 participants
@mcortes19 @mariannuar