Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop prefixer #3296

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Drop prefixer #3296

wants to merge 2 commits into from

Conversation

Andarist
Copy link
Member

closes #2747

IMHO, this plugin is not really needed in 2025, but I haven't rechecked whether all the included rules are obsolete. Many are, we definitely shouldn't be prefixing flexbox

@Andarist Andarist requested a review from emmatown December 15, 2024 11:26
Copy link

changeset-bot bot commented Dec 15, 2024

🦋 Changeset detected

Latest commit: 37fa86e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@emotion/styled Major
@emotion/cache Major
@emotion/react Major
@emotion/css Major
@emotion/primitives-core Major
@emotion/server Major
@emotion/native Major
@emotion/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically agree with this (and probably agree with shipping it in the next major in a way that I don't really with #3294) with the caveat that to understand whether all of it is actually obselete, it'd be good to see something like: run the stylis prefixer over some specifically generated css to exercise all the properties that stylis prefixes, compare that with caniuse/mdn compat data/whatever and see what we get

@Andarist
Copy link
Member Author

Quick look on caniuse:

declaration browser support notes
color-adjust 19% deprecated
animation, animation-(delay|direction|duration|fill-mode|iteration-count|name|play-state|timing-function) 97%
text-decoration 83% 97% with prefixes
filter 98%
clip-path 95%
backface-visibility 97%
column 97%
box-decoration-break 69% 98% with prefixes
mask, mask-image, mask-(mode|clip|size), mask-(repeat|origin), mask-position, mask-composite, 92.5% 98% with prefixes
background-clip 97%
columns, column-(count|fill|gap|rule|rule-color|rule-style|rule-width|span|width) 97%
appearance 96%
user-select 79% 97% with prefixes
transform, 98%
hyphens 94%
text-size-adjust 77% 92% with prefixes
transition 97%
cursor 80% no change with prefixes
background, background-image 97%
(margin|padding)-inline-(start|end) 97%
(min|max)?(width|height) 97%
(min|max)(inline-size|block-size) 96%
stretch, max-content, min-content, fill-available 97%
(m)ax-content, (m)in-content 97%
(f)ill-available, (f)it-content 97%
(s)tretch 98%
position: sticky 97%
writing-mode 98%
vertical-l(r) 97%
vertical-r(l) 97%
horizontal(-)tb 97%
:read-(only|write) 98%
:placeholder 97.7%

@Andarist Andarist requested a review from emmatown December 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants