-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-version documentation #317
base: main
Are you sure you want to change the base?
Conversation
56f2656
to
772381d
Compare
bbf8ca6
to
53012d3
Compare
1cbb080
to
0f331a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need any preparation? this repo has enver had the corresponding branch used unlike the fork so I wonder whether anything is implicitly expected/needed or should it just work flat out?
@@ -1,20 +1,12 @@ | |||
name: Documentation | |||
|
|||
on: | |||
push: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding stuff that still needs to be changed on the repo side:
- There is already a prepared gh-pages branch in this repo
- We only need to change the settings in this repo to deploy from that branch instead of using github actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AVHopp, thanks for getting this to work 👍🏼 I'm also currently trying to get the lockfile running, and then we have all missing pieces ready for a first multi-version doc!
7a00ffe
to
8682e7b
Compare
2c996a1
to
4f098cc
Compare
e23935b
to
6da823b
Compare
f69d1ba
to
aa0e994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AVHopp. Thanks for taking care of this. There is so much custom html stuff involved that it is really hard for me to review. But the main requirement are:
- it does its job
- you've tested it
- the code is in a clean enough form for you so that you won't freak out when we notice that another change is required in 2 weeks time :D
So I guess all that is fulfilled, so accept 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the hotfix logic is not yet explained in the PR description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will include, do you want to check it then or just have it for the sake of it being documented?
f5e13bb
to
b23537c
Compare
This reverts commit f5e13bb.
4debbb7
to
d4711cc
Compare
This PR introduces the multi-version documentation.
The logic is the following:
gh-pages
was created. On this branch, the actual documentation is hosted. For each version of the documentation, includingstable
andlatest
, there is one folder containing the actual documentation. This makes the folders reachable via URLs once the settings in the repository have changed.stable
version is included for "backwards compatibility". Note however that this version does not yet contain the version selector and won't until the next release!docs
workflow will be triggered:latest
folder and updates it.latest
,stable
andX.Y.Z
, whereX.Y.Z
is the tag that was used in the release.stable
is being created, an announcement banner saying that this is not the stable version is included. Also, a "version selector" is injected, showing both the current version and providing a link to the (currently not nice looking) page for switching the version.gh-pages
branch was designed such that it is as minimal as possible. Thus, all actual python scripts and logic is contained in the actual branch and is being copied frommain
whenever the documentation is built.For testing, I created the exact same Pull Request as well as as "dummy release" on my fork and merged both of these/created a new release, so please have a look at https://avhopp.github.io/baybe_dev/stable/ for details.