Ignore UnusedObjectWarning caused by nonpred recommenders in simulation
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scienfitz
force-pushed
the
fix/simulation_warnings
branch
2 times, most recently
from
5f63ffe
to
71c4b87
Compare
AVHopp
requested changes
Jul 21, 2024
Scienfitz
force-pushed
the
fix/simulation_warnings
branch
from
71c4b87
to
f2de562
Compare
AdrianSosic
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Hi @Scienfitz, sorry for taking so long. Here only one question/comment.
Scienfitz
force-pushed
the
fix/simulation_warnings
branch
from
f2de562
to
9bbe6cf
Compare
AdrianSosic
reviewed
Jul 22, 2024
AdrianSosic
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnusedObjectWarningcaused by recommenders in simulationsRandomRecommender, a common use case because its a baselineonceandmodulebut that didnt work at all