Support for Liferay 7.3.1 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akakunin
reviewed
Apr 22, 2020
gradle.properties
Outdated
| @@ -53,7 +53,7 @@ | |||
| # Liferay Portal CE 7.2 GA2, or Liferay Portal CE 7.3 GA1, depending on the | |||
| # portal version the workspace is targeting. | |||
| # | |||
| liferay.workspace.bundle.url=https://releases-cdn.liferay.com/portal/7.2.0-ga1/liferay-ce-portal-tomcat-7.2.0-ga1-20190531153709761.tar.gz | |||
| liferay.workspace.bundle.url=https://releases-cdn.liferay.com/portal/7.3.0-ga1/liferay-ce-portal-tomcat-7.3.0-ga1-20200127150653953.tar.gz | |||
There was a problem hiding this comment.
Не думаю что принципиально - но наверное лучше тут указать для скачивания сразу именно версию 7.3.1
|
PR лучше делать в отдельную ветку, создал отдельную ветку для 7.3 - https://github.com/emdev-limited/caldav-sync/tree/7.3 |
|
Нужно сохранить отступы с оригинальных jsp. Сначала нужно сделать init commit исходного файла как есть, а затем добавить только необходимые изменения. |
added 7 commits
May 18, 2020 23:41
# Conflicts: # gradle.properties # override/calendar-hook/bnd.bnd # override/calendar-hook/build.gradle # override/calendar-hook/src/main/resources/META-INF/resources/view_calendar_menus.jspf
…sync into development-7.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for LF 7.3.1 + links in LF calendar