Test JsonPointerBasedFilter with sequence of JSONs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikurube
force-pushed
the
test-JsonPointerBasedFilter-with-sequence-of-jsons
branch
2 times, most recently
from
7aa4934
to
5411f8c
Compare
dmikurube
force-pushed
the
test-JsonPointerBasedFilter-with-sequence-of-jsons
branch
from
5411f8c
to
be9a641
Compare
hiroyuki-sato
approved these changes
Sep 20, 2023
| public class TestJacksonFilter { | ||
| @Test | ||
| public void testFilterSequenceSkippingNonMatch() throws IOException { | ||
| final com.fasterxml.jackson.core.JsonParser parser = createFilteredParser( |
There was a problem hiding this comment.
What do you think to add this comment ?
Because, I completely understand the purpose of this test after reading the google group article.
// This |parser| returns {"bar":"baz"}, and {"bar":"qux"}, with just skipping {"xxx":{"yyy":"zzz"}}.There was a problem hiding this comment.
Thanks. Sounds good! Added.
dmikurube
deleted the
test-JsonPointerBasedFilter-with-sequence-of-jsons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a test for
embulk-util-jsonby itself, but to check the behavior of Jackson.A related topic: https://groups.google.com/g/jackson-user/c/bLZTjjjXZ28