Adding PostgreSQL 13 and MySQL 8.3 to GitHub Actions.

[hiroyuki-sato]

• Adding PostgreSQL 13 and MySQL 8.3 to GitHub Actions.
• Change JDK image temurin to zulu.

[dmikurube]

Left some comments and suggestions.

[dmikurube]

What are the password mechanism1 and the password mechanism2 ? Can you leave a link to a kind of official documents?

[hiroyuki-sato]

Let's remove mechanism1 and mechanism2.
The first part(mechanism1) is for root@localhost
The second part(mechanism2) is for root@%

• Change password mechanism1 (root@localhost) -> Change password (root@localhost)
• Change password mechanism2 (root@%) -> Change password (root@%)

[dmikurube]

For account names like ...@localhost and ...@%, you may want to leave a link to: https://dev.mysql.com/doc/refman/8.4/en/account-names.html

[hiroyuki-sato]

• Simplified. (Remove some steps).
• Removed mechanism[12] words
• Add URL https://dev.mysql.com/doc/refman/8.4/en/account-names.html

[dmikurube]

What does this mean?

[hiroyuki-sato]

It meant the mark of the end of the workaround.

embulk-output-jdbc/.github/workflows/check.yml

Lines 81 to 96 in 8a99944

	# This part change password mechanism to mysql_native_password.
	# Remove the following part after update Connector/J
	#
	- name: Show password plugins
	run: mysql -h 127.0.0.1 --port 3306 -uroot -proot -e "SELECT user, host, plugin FROM mysql.user;"
	- name: Change password mechanism1 (root@localhost)
	run: mysql -h 127.0.0.1 --port 3306 -uroot -proot -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY 'root';"
	- name: Change password mechanism2 (root@%)
	run: mysql -h 127.0.0.1 --port 3306 -uroot -proot -e "ALTER USER 'root'@'%' IDENTIFIED WITH mysql_native_password BY 'root';"
	- name: FLUSH PRIVILEGES
	run: mysql -h 127.0.0.1 --port 3306 -uroot -proot -e "FLUSH PRIVILEGES;"
	- name: Show password plugins2
	run: mysql -h 127.0.0.1 --port 3306 -uroot -proot -e "SELECT user, host, plugin FROM mysql.user;"
	#
	# End caching_sha2_password workaround.
	#

[dmikurube]

Rather than such a beginning mark and an end mark, I'd suggest to leave individual comments for each step.

[hiroyuki-sato]

Removed beginning mark and an end mark

[hiroyuki-sato]

@dmikurube Thank you for your review. I'll fix it later.

[hiroyuki-sato]

@dmikurube Thank you for your review. Please retake a look when you have time.

[dmikurube]

It basically looks good, then approved, but left a couple of additional comments. Please go ahead with addressing those comments.

[dmikurube]

Is this FLUSH PRIVILEGES required to make the password (mechanism) changes effective? If then, can you explain it in the comment?

[hiroyuki-sato]

I've misunderstood about flush privileges. It was not require. So, I remove it.

[hiroyuki-sato]

@dmikurube Thank you for your review. I fixed your comments I'll merge them later.

[hiroyuki-sato]

Thanks!