This repository has been archived by the owner on Nov 11, 2017. It is now read-only.
fix click events re-propogation on mobile #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes emberjsGH-170 Previously, we did not fire a click event for touch events on mobile unless the event target was a form field. This is incorrect as the event was not `preventDefault`'d before. As you can see on Lines 48-50 in 0e596c (not the commit that introduced the bug, just a hard link reference), the "begin scroll" handler does not preventDefault on the event if it is a form field, so we do not need to re-propogate it in `synthesizeClick`. All other tag types *do* need to synthesize the click event on mobile however. I ran the tests in the XCode simulator and they passed.
|
Oh wow, guess my tired eyes missed #112 by @jmonma. Glad we came up with a similar fix though. :) |
stefanpenner
added a commit
that referenced
this pull request
Jan 19, 2015
fix click events re-propogation on mobile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes GH-170
Previously, we did not fire a click event for touch events
on mobile unless the event target was a form field. This is
incorrect as the event was not
preventDefault'd before.As you can see on Lines 48-50 in https://github.com/emberjs/list-view/blob/0e596c9c629fa076e9089e787bb2e360b8efccb6/packages/list-view/lib/virtual_list_scroller_events.js#L48-50 (not the commit
that introduced the bug, just a hard link reference),
the "begin scroll" handler does not preventDefault
on the event if it is a form field, so we do not need
to re-propogate it in
synthesizeClick.All other tag types do need to synthesize the click
event on mobile however.
I ran the tests in the XCode simulator and they passed.