Adds the option to specify files that need a third pass of UseRev #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @rickharrison |
whanchong
added a commit
to whanchong/broccoli-asset-rev
that referenced
this pull request
Feb 9, 2021
changes from this MR ember-cli#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort-of FIXES #29 (or more like works around it).
For cases where you know which files have references to other files that are in the replaceExtensions (by default JS, HTML, CSS) we can explicitly add those to a new
filesForThirdPassoption. This solution works for MiguelMadero/ember-cli-bundle-loader#32 and could likely work for others as well.For cases where dependencies are not well understood at configuration time, a better solution might be needed like what Nathan suggested on #29