Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added gte models #1539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Added gte models #1539

wants to merge 2 commits into from

Conversation

KennethEnevoldsen
Copy link
Contributor

Related to #1515

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

x-tabdeveloping
x-tabdeveloping reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@x-tabdeveloping x-tabdeveloping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Does this clash with the other PR (#1436 )? If so, should we merge and resolve conflicts later?

@KennethEnevoldsen
Copy link
Contributor Author

Let us merge the other one first

@isaac-chung
Copy link
Collaborator

#1436 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-tabdeveloping x-tabdeveloping x-tabdeveloping left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KennethEnevoldsen @isaac-chung @x-tabdeveloping