Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS `vscode-js-debug' Installation and Integration #736

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jeff-phil
Copy link

Add latest vscode-js-debug adaptor, update installation routines so vscode adaptors on Github can be easily installed. In order to make this work, updates for the latest DAP Spec for reverse requests. A few other minor updates.

Please let me know if any questions at all.

Add latest vscode-js-debug adaptor, update installation routines
so vscode adaptors on Github can be easily installed.  In order to
make this work, updates for the latest DAP Spec for reverse
requests.
@yyoncho
Copy link
Member

yyoncho commented May 5, 2023

There are some bits that should go in, and there are some pieces better to have from the other implementation. Let me think about it.

@jeff-phil
Copy link
Author

Sounds great. Definitely try it out, and let me know if have any questions about what I've done, or want me to make changes, or anything else.

Thank you for taking the time to look at it!

@jeff-phil
Copy link
Author

Hi @yyoncho - Just checking if need anything from me on this PR. Let me know if you do.

jeff-phil and others added 3 commits August 5, 2023 01:37
+ Remove child debug session from dap--debug-configuration, if
added.  This will allow `dap-debug-last' command to work using
parent.
+ Other general long line reformatting to make more readable.
@jeff-phil
Copy link
Author

jeff-phil commented Aug 5, 2023

Resync'd with master.

Then made a update for dap-js-debug.el to work with dap-debug-last command; since the skeleton child debug configuration was being added to dap--debug-configuration variable after starting the child debug. Needed to be popped off the list so that the parent debug conf is the last dap-debug.

Probably should determine a more upstream option for not adding the child confs automatically when starting debug, if the reverse request child debug sessions becomes more common. For example, should there be logic in dap-start-debugging-noexpand to not add when type is missing - which is the case according to the spec. E.g.:

(when type
    (push (cons session-name launch-args) dap--debug-configuration))

What I did for now was look if __pendingTargetId which is from vscode-js-debug adapter in the last configuration and is the child. That should be future proof regardless of how main dap-mode.el wants to handle.

Please, as always, let me know if have questions or feedback! Thanks so much!

zeorin added a commit to zeorin/dap-mode that referenced this pull request Apr 22, 2024
Shamelessly stolen from emacs-lsp#736
zeorin added a commit to zeorin/dap-mode that referenced this pull request Apr 22, 2024
Shamelessly stolen from emacs-lsp#736
zeorin added a commit to zeorin/dap-mode that referenced this pull request Jun 19, 2024
Shamelessly stolen from emacs-lsp#736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants