fix for java compile/attach args #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbfalcon
approved these changes
Nov 7, 2020
nbfalcon
reviewed
Nov 7, 2020
| (port (dap--find-available-port "localhost" dap-java-compile-port)) | ||
| (program-to-start (format "%s -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=%s,quiet=y -cp $CLASSPATH_ARGS %s" | ||
| (program-to-start (format "%s -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=%s,quiet=y -cp $CLASSPATH_ARGS %s %s" |
There was a problem hiding this comment.
Suggested change
| (program-to-start (format "%s -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=%s,quiet=y -cp $CLASSPATH_ARGS %s %s" | |
| (program-to-start (format "%s -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=%s,quiet=y -cp $CLASSPATH_ARGS %s%s" |
nbfalcon
reviewed
Nov 7, 2020
| lsp-java-java-path | ||
| port | ||
| mainClass))) | ||
| mainClass | ||
| args))) |
There was a problem hiding this comment.
Suggested change
| args))) | |
| (and args (concat " " args))))) |
This will remove a trailing whitespace in the command, also handles the case of args being nil or unspecified.
|
This PR should be against lsp-java, dap-java was moved there. I am amazed how this PR is green considering that dap-java.el is not present in this repo... |
Sorry, I saw I can move this to lsp-java? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Args are passed in when doing a compile/attach. This small fix addresses this issue.