Update dap-python for running in pipenv

[MokkeMeguru]

We have many options for executing the python program.
At first, I want to add "pipenv" into the option.

[ericdallo]

I think string= is better for string comparison.
Is there any reason for virtualenv-type to be a string? a symbol could fit better, what do you think?

[MokkeMeguru]

I afraid that symbol will pollute global variables... (I know emacs-lisp a bit.)
string= is better

[MokkeMeguru]

If the symbol is correct in terms of emacs lisp, please tell me.

[nbfalcon]

Symbols don't pollute the global namespace, unless you intern them, which you needn't do. A symbol ('foo) is just a lisp object like an int, string, .... You could use (eq virtualenv-type 'pyenv) instead of (= virtualenv-type "pyenv"), the latter invalid anyway since = can only compare ints and markers.

[yyoncho]

@mpanarin, willing to take a look?

[mpanarin]

It is the same as #202
To be honest, I am against explicit support of the virtualenv in lsp-mode or dap-mode.
This should be handled by emacs and its executable-find. There are a bunch of packages and minor-modes that will make executable-find find a proper python in virtualenv. I mentioned a few in the issue above.

The problem with supporting virtualenvs is that everyone uses them differently. You can use them through pipenv, 'virtualenv', 'virtualenvwrapper', 'poetry' to name a few. And I don't think we should write support for all of them.
pyenv is a bit different as it is not really a virtualenv, so we have a direct support for it.

But I am definitely open for a discussion @ericdallo @seagle0128 @yyoncho

[ericdallo]

I agree with @mpanarin, IMO we should make dap-mode extensible and easy to setup with different templates, support all possible virtualenvs seems to be too much.

[MokkeMeguru]

But now you are supported pyenv. If you want to do so, you should remove pyenv option, shouldn't you?

[MokkeMeguru]

In my opinion, we can give the execute-python-path into a template.
Can you fix it?

[mpanarin]

@MokkeMeguru pyenv is a version manager, not a virtualenv manager.
As I said, it is a different story, so we support it explicitly

[MokkeMeguru]

If so, then we must consider conda, and Pyflow... It will be too complex problem...

[greboide]

So how to run dap on python with pipenv? No way?

[htgoebel]

@MokkeMeguru @mpanarin Since this pull-request is not accepted and #294 is an alternative: can this one be closed?

[MokkeMeguru]

hi @htgoebel
IMO, this pr can be closed.
thanks for your review