Update timer operations with new time type (secs24p8) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcohler
reviewed
Oct 7, 2024
biosbob
commented
Oct 7, 2024
There was a problem hiding this comment.
almost all compilers will "optimize" multiply / divide by powers of two as a << or >> respectively.... i acltually prefer the shift operators, since i know what's happening.... 65536 feels like "more" of a magic number than 1 << 16 does...
i'm also trying to encapsulate these formulas as much as possible – ultimately in a concrete Secs_24p8 struct type that otherwise incurs no additional runtime overhead....
|
OK. Let me know if you want me to merge etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major refactor/cleanup of WakeupTimer + Uptimer functionality....
before merging into staging, we should "fine-tune" any names for clarity....
Closes #38