ci: fix warnings and notices when compiling with latest V 0.4.0 320057d #159
Conversation
…7d, after the deprecation of the .microsecond field of time.Time, and the notice about uninitialised fn callback fields
spytheman
changed the title
| @@ -23,67 +23,6 @@ fn catalog_name_from_path | |||
|
|
|||
|
|
|||
|
|
|||
| fn new_varchar_value | |||
There was a problem hiding this comment.
I think the build is failing because there are coming are not being written in a deterministic order. I think you need to add a sort here: https://github.com/elliotchance/vsql/blob/main/scripts/generate-v-client-library-docs.vsh#L32
There was a problem hiding this comment.
All right, they are now sorted with dcs_contents.sort_by_kind() .
There was a problem hiding this comment.
For me, running make clean-docs docs does not change the order.
There was a problem hiding this comment.
Looks like there are some legitimate build failures now.
There was a problem hiding this comment.
Looks like there are some legitimate build failures now.
Indeed. Given that vsql has not changed since May, I think there is a codegen regression in V. I'll bisect later today to see when it happened and what caused it.
It could also be related to the .microsecond -> .nanosecond change in the time module, but that seems less likely to me.
|
Thanks for the effort, but I've cleaned this up with #160 |
After the deprecation of the .microsecond field of time.Time, and the addition of a notice about uninitialised fn callback fields, vsql can not be compiled cleanly with just
make bin/vsql.This PR fixes it.