Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): change apple app status bar style #2903

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DasLixou
Copy link
Contributor

@DasLixou DasLixou commented Jul 5, 2024

image

On my iPhone, with a PWA, the status bar is always white, which makes it unreadable in white mode.

In this PR, I try to get this to work with the selected theme.

Because I don't know how to debug it differently, I'll use the hosted PR example to test.

Closes #2384

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 189af46
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6688175629462e0007c3cf77

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 189af46
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/66881756b6ec1900089622a7
😎 Deploy Preview https://deploy-preview-2903--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DasLixou
Copy link
Contributor Author

DasLixou commented Jul 5, 2024

image
Well that was easier fixed than I imagined.

plugins/color-mode.ts Outdated Show resolved Hide resolved
@userquin userquin changed the title Update color-mode.ts fix(ui): include apple app status bar color Jul 5, 2024
@userquin userquin changed the title fix(ui): include apple app status bar color fix(ui): include apple app status bar style Jul 5, 2024
@userquin
Copy link
Member

userquin commented Jul 5, 2024

uhmm, we should just switch the flag here: https://github.com/elk-zone/elk/blob/main/nuxt.config.ts#L264

@DasLixou can you send a new PR changing to default previous line?

@userquin userquin changed the title fix(ui): include apple app status bar style fix(ui): change apple app status bar style Jul 5, 2024
@DasLixou
Copy link
Contributor Author

DasLixou commented Jul 5, 2024

uhmm, we should just switch the flag here: https://github.com/elk-zone/elk/blob/main/nuxt.config.ts#L264

@DasLixou can you send a new PR changing to default previous line?

Oh interesting it was already there :0 yeah, can do that, but I'll do it in here to track everything

@DasLixou
Copy link
Contributor Author

DasLixou commented Jul 5, 2024

I was wondering why an explicit default would change something but with the other line being overwritten that makes sense

@userquin
Copy link
Member

userquin commented Jul 5, 2024

switching to dark theme should also work, can you confirm that?

@DasLixou
Copy link
Contributor Author

DasLixou commented Jul 5, 2024

switching to dark theme should also work, can you confirm that?

I tested that with my old changes yes, and the new one set the same property, so it should work

@DasLixou
Copy link
Contributor Author

DasLixou commented Jul 5, 2024

yep, works.

Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPadOS Safari displays status bar with light text in light theme
2 participants