Update human_pathogen_genomics.md #1526
Conversation
bianchini88
commented
Sep 13, 2024
•
bianchini88
commented
- Improving the page style (closes General curation of the human pathogen genomics page #1530)
- Adding tools with the right syntax (closes add tools in Human pathogen genomics #1345)
- Adding references to bibliography (closes Creating a bibliography for the human pathogen genomics domain page #1524)
* Improving the page style. * Adding tools with the right syntax
|
@bianchini88 do you want me still to do something for this? |
|
Hi @bedroesb, sorry it is a particularly busy period. I will finish this by the end of October, if it's ok with you, |
Adding missing FAIRsharing ID to an ontology
Adding the Genomic Epidemiology Ontology (GenEpiO) to the table of resources
Genepio moved to tool syntax
general style-related improvements
Adding the Phenotypic QualiTy Ontology (PATO) to the table of resources
Adding Chemical Entities of Biological Interest (ChEBI) to the table of resources.
Adding UBER anatomy ONtology (UBERON) to the table of resources
Tools syntax for various ontologies.
Changing id for bio.tools to match the table
|
@bedroesb I think we need to address the discussion points I raised above, and then we can possibly merge this as it is becoming long enough. The bibliography bit can safely be added as a future PR, I believe. |
Removing "tool" syntax for projects and organisations.
Removing organisations and projects from the table of resources.
Minor style improvements
Adding missing author to the list of contributors (permission obtained via private communications with the author)
Improved affiliation of author (now matches main label on ROR)
|
@bedroesb I had a bit of extra time and I ended up adding also the bibliography as part of this PR. I will be opening this for reviewers now. |
|
I submit suggestions and comments as a single review but it looks huge at the end. |
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
|
Thank you @marikapop for going through this. I have committed all the suggestions but one (see above).
I am not sure why it looked the way it did (some suggestions were doubled somehow), but I would say this is the correct approach for reviewing a page. |
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
Co-authored-by: Marina Popleteeva <[email protected]>
|
@bianchini88 this is really great! Maybe even enough to highlight it with a news item? |
Thank you @bedroesb. The content in itself did not really change, but adding a news item is always a good idea. |
Thank you Federico. Then I will continue making review this way :) |
|
@diana-pilvar or @marikapop do you give an official approval? Because I think this one is ready to be merged. Accept if Federico wants to add the news item as part of this PR, otherwise we do it after. |
|
@bedroesb Shall we merge? |
|
Lets merge! |
