Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pullapprove config file #8

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ESapenaVentura
Copy link
Collaborator

Changelog

Added pullapprove config file with the following features:

  • Whenever a pull request is opened, @lauraclarke @clairerye and @mcourtot will be notified.
  • Pullapprove will wait until travis test passes
  • Pullapprove will send a warning comment to the author if they try to push directly into master.

I haven't added it, but other possible interesting features we could add would be:

  • PR review group: With a list of specific people that will be tagged as reviewers whenever a PR is requested. These people will be selected randomly from the list each time.
  • Labels to skip pullapprove: Labels like "hotfix", "bugfix", etc won't trigger pullapprove

@ESapenaVentura
Copy link
Collaborator Author

On another note, @ke4 @rolando-ebi Where is the travis-test the travis config file refers to?

https://github.com/elixir-europe/json-schema-validator/blob/master/.travis.yml#L4

I can't see any travis status in the PRs, which seems pretty weird. This clarification is needed for this PR as one of the conditions for pullapprove to work (With this config) is for the travis build to be successful

@ke4
Copy link
Collaborator

ke4 commented Dec 7, 2020

@ESapenaVentura
Travis test defined here:

"travis-test": "jest test/elixir-validator.test.js"

@ke4 ke4 mentioned this pull request Dec 7, 2020
@ESapenaVentura ESapenaVentura marked this pull request as draft December 7, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants