-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update human biomolecular data sources page #155
Conversation
@M-casado to review |
Yesterday we had a meeting to see if we merge the data sources pages for human biomolecular and human clinical health data ant for the moment we will leave them separate and reference them when necessary, as the information they contain right now is different. |
Writing a FAIRness page, which is not one of the pages we decided to have in IDTk, was a risky thing I think :) This needs more discussing imo! |
Hi @bedroesb, The FAIRness content was reviewed and, albeit a few details, is mostly done. As soon as it is discussed, we can continue with this conversation 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the document from GitHub. Besides the smaller comments, I have two overall comments:
- We definitely need to merge the two pages (Merge Human Biomolecular and Clinical data #165), given how everything I read rang a bell with regards to the Human clinical data sources page.
- Wherever it may end at, I would add a mention to the FAIRness page (New FAIRness page #163) whenever speaking about discoverability, access, etc. within this page.
Edit of the changes suggested elixir-europe#155
Edit of the changes suggested #155
Add of Data Deposition part
Put links to data deposition
Update links in data deposition
Removal of Beacon training UI link
Hi @IrisVanDam :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page is really nice and structured clearly. Thanks for all the work on this!
My main concern does not relate to this page specifically, but rather that we might need to discuss (again) exactly what we are aiming to do with the data sources pages. From my understanding the aim was to give the user information on where to find these types of data and how to access them (~secondary use of the data). However, this page seems to be more focused on what to do with your own data as a researcher. I think both approaches are fine, but for the IDTk that we should choose one approach for all pages as to ensure consistency. What do you think?
Hi @IrisVanDam :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've focused on the new changes made to the page and these look wonderful. I've added a few suggestions, but nothing major :).
…oolkit into update-hbd-data-sources
new way of adding tools
Add tools in the yaml
…fectious-diseases-toolkit into update-hbd-data-sources
Add missing tools in the new way
READY TO BE MERGED! :) |
Closes #141