Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ck-49, ck-67: docs, tests in docker build, fix test, install ajv-errors #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
node_modules
npm-debug.log
examples
logs
.idea
.github
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ FROM node:18-buster
WORKDIR /usr/src/app

COPY package*.json ./
COPY ./start.sh /

RUN npm install

# Bundle app source
COPY ./start.sh /
COPY . .
RUN npm run test

ENTRYPOINT ["/start.sh"]
13 changes: 11 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,27 @@ The biovalidator currently supports JSON Schema draft-06/07/2019-09.
## Getting Started

### Prerequisites
- [Node.js](https://nodejs.org/en/about/) - v10.19.1.0+
- [Node.js](https://nodejs.org/en/about/) - v18+
- [npm](https://www.npmjs.com/)
You can also run the [biovalidator using docker](#running-in-docker) without installing node or npm.

### Installation

- Install Node.js: https://nodejs.org/en/ (v10.19.1.0+)
- Install Node.js: https://nodejs.org/en/ (v18+)
- if you are using nvm, run
```bash
nvm install 18
nvm use 18
```

- Check node and npm version
```shell
node -v
npm -v
```

- If you are using an IDE, set it to use this node version.

- Clone project and install dependencies:
```
git clone https://github.com/elixir-europe/biovalidator.git
Expand Down
14 changes: 7 additions & 7 deletions examples/objects/isValidTerm.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
{
"attributes": {
"sex": [
"organ": [
{
"value": "female",
"value": "lungs",
"terms": [
{
"url": "http://purl.obolibrary.org/obo/PATO_0000383"
"url": "http://purl.obolibrary.org/obo/UBERON_0000170"
}
]
}
],
"breed": [
"organism": [
{
"value": "Spanish Churra",
"value": "Eukaryota",
"terms": [
{
"url": "http://purl.obolibrary.org/obo/LBO_0000704"
"url": "http://purl.obolibrary.org/obo/NCBITaxon_2759"
}
]
}
Expand All @@ -41,4 +41,4 @@
}
]
}
}
}
Loading