Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mars receipt exception #96

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Mars receipt exception #96

wants to merge 12 commits into from

Conversation

Pedram-A-Keyvani
Copy link
Collaborator

Showing errors in MARS receipt in the happening of:

  • MarsReceiptException that are custom errors from the API
  • Exception for catching all the other errors

CAUTION: The receipt errors might contain technical information

@Pedram-A-Keyvani
Copy link
Collaborator Author

#67 closed

@bedroesb bedroesb linked an issue Dec 4, 2024 that may be closed by this pull request
Repository API receipt error catching #67
Open
apriltuesday
apriltuesday approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As we discussed, I think this will help us start handling errors in the CLI, so we can continue to iterate on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apriltuesday apriltuesday apriltuesday approved these changes

@kdp-cloud kdp-cloud Awaiting requested review from kdp-cloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repository API receipt error catching
2 participants
@Pedram-A-Keyvani @apriltuesday