Multi auth provider credentials #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +114,7 @@ def submission( | |||
| # Submit to Biosamples | |||
| biosamples_result = submit_to_biosamples( | |||
| isa_json=isa_json, | |||
| biosamples_credentials=user_credentials, | |||
| biosamples_credentials=user_credentials[TargetRepository.BIOSAMPLES.value], | |||
There was a problem hiding this comment.
Should this be AuthProvider.WEBIN.value instead? (And same for the ENA usages below)
Not sure if we need some kind of TargetRepository -> AuthProvider mapping, or whether just defining it implicitly in this method is enough.
|
|
||
| if not all( | ||
| repo in AuthProvider.available_providers() for repo in credentials.keys() | ||
| ): |
There was a problem hiding this comment.
I think eventually should loosen this up, e.g. if I'm only submitting the ENA, EVA and BioSamples I shouldn't need Metabolights credentials... it's fine for now though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the authentication to incorporate multiple sets of credentials, which are repository specific.