Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding jsonata_validate prototype #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

adding jsonata_validate prototype #71

wants to merge 5 commits into from

Conversation

xiaoranzhou
Copy link
Collaborator

No description provided.

@xiaoranzhou xiaoranzhou requested a review from kdp-cloud November 7, 2024 15:33
kdp-cloud
kdp-cloud requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@kdp-cloud kdp-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add jsonata-python to requirements.txt?
I think this would be better in mars_lib/valdate.py than next to the CLI main file but you would preferably remove all the try / excepts first. This can be done later as well...

mars-cli/jsonata_validate.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdp-cloud kdp-cloud kdp-cloud requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoranzhou @kdp-cloud