Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GA cookies #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: GA cookies #26

wants to merge 2 commits into from

Conversation

anuragxxd
Copy link
Member

Description

Fixes #10

This pull request addresses several important aspects:

  • Google Analytics Support: The primary objective is to integrate Google Analytics support into our landing page. This will enable us to gather valuable insights into user behavior and engagement.

  • Simplifying Consent Management: It also resolves the issue highlighted in this discussion by streamlining the consent management process. Instead of relying on two additional libraries, we are now reducing unnecessary bloat in our codebase.

  • Enhanced Consent Control: To manage user consents efficiently, we are leveraging Google's Official consent support. With this implementation, the Google Analytics tag will load on the initial page render, but tracking will not commence until the user explicitly clicks the "Accept" button. Additionally, if a user declines tracking, this decision will be conveyed to the Google Analytics dashboard, ensuring transparency and compliance with privacy regulations.

  • Changed the way env variables were managed in the repo for the more dynamic use.

These improvements aim to enhance the user experience, streamline our codebase, and provide more precise control over data collection and user consents.

@vercel
Copy link

vercel bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
krini ✅ Ready (Inspect) Visit Preview Sep 24, 2023 1:15pm

@anuragxxd anuragxxd requested a review from uniqueg September 24, 2023 13:15
@anuragxxd anuragxxd changed the title Cookies feat: GA cookies Sep 24, 2023
@anuragxxd
Copy link
Member Author

Hey @uniqueg, before merging it is good to note for suitable working of this app in the prod it will require the .env file or the environment variables available in the production.

These are the required env's:

REACT_APP_HOST_URI=https://krini.rahtiapp.fi/
REACT_APP_GA_MEASUREMENT_ID=G-XXX

I have sent the details in the DM to you for more info.

@uniqueg
Copy link
Member

uniqueg commented Oct 24, 2023

@git-anurag-hub LGTM. Is there anything I should do here with respect to the env vars, or was that just FYI? If all is fine from your side, please go ahead and merge

@anuragxxd
Copy link
Member Author

anuragxxd commented Oct 24, 2023

@git-anurag-hub LGTM. Is there anything I should do here with respect to the env vars, or was that just FYI? If all is fine from your side, please go ahead and merge

Yes, you will have to add the above env variables in the app environment. IG the app in currently running and deployed on open shift as I can see https://github.com/elixir-cloud-aai/krini/blob/master/.github/workflows/open-shift-deployment.yml#L83.
@uniqueg

@uniqueg
Copy link
Member

uniqueg commented Oct 24, 2023

Oh, okay, thanks for keeping my shit together :)
Let's do it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Analytics support
2 participants