Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'versions-updated' #281

Merged
merged 5 commits into from
Nov 6, 2023
Merged

'versions-updated' #281

merged 5 commits into from
Nov 6, 2023

Conversation

SanjayRam07
Copy link
Contributor

@SanjayRam07 SanjayRam07 commented Nov 6, 2023

updated maven-release-plugin from 2.5.3 to 3.0.1
updated maven-scm-provider-gitexe from 1.11.3 to 2.0.1
updated maven-scm-api from 1.11.3 to 2.0.1
updated gson from 2.9.1 to 2.10.1

note: these updates are made in pom.xml file and java version is not updated

@SanjayRam07 SanjayRam07 requested a review from a team as a code owner November 6, 2023 12:58
@SanjayRam07 SanjayRam07 requested review from jpatel3, jo-elimu and vrudas and removed request for a team November 6, 2023 12:58
Copy link
Member

@nya-elimu nya-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayRam07 Looks good 👍🏽

After you merge your pull request, please test if it still works to perform a release by going to https://github.com/elimu-ai/model/actions and run the Maven Release workflow.

@jo-elimu
Copy link
Member

jo-elimu commented Nov 6, 2023

ref #280

@SanjayRam07 SanjayRam07 merged commit 817de8c into main Nov 6, 2023
@SanjayRam07 SanjayRam07 deleted the update-java11 branch November 6, 2023 16:44
@SanjayRam07
Copy link
Contributor Author

@SanjayRam07 Looks good 👍🏽

After you merge your pull request, please test if it still works to perform a release by going to https://github.com/elimu-ai/model/actions and run the Maven Release workflow.

yeah, I merged and ran the workflow. It succeeded

@nya-elimu nya-elimu mentioned this pull request Nov 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants