Refresh go-home and align with other go- icons
#1294
Conversation
|
It looks like this has conflicts now. Can you resolve those please? :) |
|
It also looks like the icon in #1094 is the 24px version, so you'll need to make sure to update that one as well |
There was a problem hiding this comment.
Couple problems here with like positioning and size. If you look at for example the home icon in an entry at 16px, it's really crammed up against the top edge now. It doesn't look vertically centered:
In terms of scale, if you were to take the 24px version and scale it down at the same time as another icon it's commonly next to (like the arrow) you can see that this 16px version is a lot larger than the arrow:
Pictured here in red is how large the home icon would be if it was scaled proportionally to the arrow icon. You can really see also how the length of the chimney is significantly different between these sizes
And also it looks like you haven't merged down these shapes :)
Hmm, that might be an artifact of my misidentifying the problem in the original screenshot. I believe (Ill check a little later) that 'view-refresh' is top aligned when I looked at the file, so I matched that alignment here. Centering home will likely reintroduce the alignment issue present in the screenshot without some compensation in refresh. Ill fix the alignment here, but I want to do some investigating to see whether all of the view icons are like that. |
|
Yeah so, if I remember correctly, the top of the arrow in the refresh icon does reach the top of the canvas, but the actual circular body of the icon is vertically centered. So it's okay to have elements that are like ascenders and descenders, but you also have to make sure the visual weight of the icon is centered |
wpkelso
changed the title
go-home with other go- iconsgo-home and align with other go- icons
Closes #1094
Refreshes
go-hometo use standard fill color, unifies it's corner radii with othergo-icons, and move it's baseline up by two pixels to align with othergo-icons