-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACKEE_BASEURL configuration. #317
base: master
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @electerious on Vercel. @electerious first needs to authorize it. |
I've added an automatic redirect from I also noticed I forgot to update the healthcheck.js url's. |
Hello @electerious, have you had time to check my work? If there's anything I can do to get this pull accepted please let me know 👍 . I also just saw the other pull request for a base URL option (#288). I honestly did not see that before. I'm not trying to step on anyone toes, and I'm sure either of these pulls will do the job just fine 🙂. |
Hey @electerious,
I took a jab at implementing some sort of base URL support. Can you give this a test run and tell me what you think?
I wrote some documentation as well.
One downside of this implementation is that withACKEE_BASEURL=/ackee
the server listens onexample.com/ackee/
, but not atexample.com/ackee
. This is because the relative paths need the trailing/
(at least, I think so. Couldn't get it to work otherwise). It's not a breaking bug, and it's easily solved by configuring a http redirect from/ackee
to/ackee/
in your reverse proxy. Maybe we could include that redirect directly in server.js?The above is now fixed.