Skip to content

Commit

Permalink
_nsi
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderkirtzel committed Jul 17, 2024
1 parent b263d9c commit 7dbad94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/destinations/web/etag/src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,15 @@ describe('Destination etag', () => {
session: { isNew: true, isStart: true, count: 1 },
});
expect(requestedUrl(mockSend)).toContain('_ss=1');
// expect(requestedUrl(mockSend)).toContain('_nsi=1');
expect(requestedUrl(mockSend)).toContain('_nsi=1');
expect(requestedUrl(mockSend)).toContain('_fv=1');
expect(requestedUrl(mockSend)).toContain('sct=1');

push(event, destination.config.custom, {
session: { isNew: true, isStart: true, count: 1 },
});
expect(requestedUrl(mockSend, 1)).not.toContain('_ss=1');
// expect(requestedUrl(mockSend, 1)).not.toContain('_nsi=1');
expect(requestedUrl(mockSend, 1)).not.toContain('_nsi=1');
expect(requestedUrl(mockSend, 1)).not.toContain('_fv=1');
});

Expand Down
2 changes: 1 addition & 1 deletion packages/destinations/web/etag/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ function getSessionParams(
const { isStart, isNew, count } = session;

if (isNew) {
// params._nsi = 1; // new to site
params._nsi = 1; // new to site
params._fv = 1; // first visit
}

Expand Down

0 comments on commit 7dbad94

Please sign in to comment.