data parameters

elbwalker · Dec 4, 2024 · 1f4cdd5 · 1f4cdd5
1 parent 36caa95
commit 1f4cdd5
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 11 deletions.
diff --git a/packages/destinations/web/piwikpro/src/index.test.ts b/packages/destinations/web/piwikpro/src/index.test.ts
@@ -66,7 +66,19 @@ describe('Destination PiwikPro', () => {
         order: {
           complete: {
             name: 'trackEcommerceOrder',
-            data: 'data.id',
+            data: [
+              'data.id',
+              'data.total',
+              {
+                fn: (event) => {
+                  const total = Number(event.data?.total ?? 0);
+                  const taxes = Number(event.data?.taxes ?? 0);
+                  const shipping = Number(event.data?.shipping ?? 0);
+
+                  return total - taxes - shipping;
+                },
+              },
+            ],
           },
         },
       },
@@ -76,6 +88,8 @@ describe('Destination PiwikPro', () => {
     expect(mockFn).toHaveBeenCalledWith([
       'trackEcommerceOrder',
       order_complete.data.id,
+      order_complete.data.total,
+      expect.any(Number),
     ]);
   });
 });
diff --git a/packages/destinations/web/piwikpro/src/index.ts b/packages/destinations/web/piwikpro/src/index.ts
@@ -49,11 +49,9 @@ export const destinationPiwikPro: Destination = {
 
     const customMapping: CustomEvent = mapping.custom || {};
 
-    func([
-      event.event,
-      data || event.entity,
-      // @TODO parameters
-    ]);
+    const parameters = Array.isArray(data) ? data : [data];
+
+    func([event.event, ...parameters]);
 
     if (customMapping.goalId) {
       const goalValue = customMapping.goalValue

diff --git a/packages/destinations/web/plausible/src/index.ts b/packages/destinations/web/plausible/src/index.ts
@@ -24,7 +24,6 @@ export const destinationPlausible: Destination = {
   },
 
   push(event, config, mapping, options = {}) {
-    console.log('🚀 ~ push ~ options:', options);
     const { fn } = config;
     const props = isObject(options.data) ? options.data : event.data;
 

diff --git a/packages/sources/node/src/__tests__/destination.test.ts b/packages/sources/node/src/__tests__/destination.test.ts
@@ -7,7 +7,6 @@ describe('Destination', () => {
   const eventCall = jest.fn();
   const mockPush = jest.fn().mockImplementation((event) => {
     eventCall(event);
-    // console.log(event);
   });
   const mockInit = jest.fn();
 

diff --git a/packages/utils/src/__tests__/eventGenerator.test.ts b/packages/utils/src/__tests__/eventGenerator.test.ts
@@ -89,8 +89,5 @@ describe('createEvent', () => {
         trigger: 'visible',
       }),
     );
-
-    // All the other events are tested in the same way
-    // console.log(getEvent('order complete'));
   });
 });