measurement plan update

elbwalker · Sep 16, 2022 · 8b86c5c · 8b86c5c
1 parent dc0b30c
commit 8b86c5c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 15 deletions.
diff --git a/220916-code_talks/measurementplan.ts b/220916-code_talks/measurementplan.ts
@@ -15,13 +15,26 @@ const plan: Measurement.Plan = {
             view: {
               name: "Pageview",
               description: "The well known pageview on each route change",
-              properties: [],
-              sources: { web: { required: true } },
+              properties: [{ id: "id", required: true }],
               trigger: { type: "load" },
               type: "core",
             },
+            read: {
+              name: "Pageread",
+              description:
+                "On reaching the end of a page by seeing the footer",
+              properties: [{ id: "id", required: true }],
+              trigger: { type: "visible" },
+              type: "core",
+            },
+          },
+          properties: {
+            id: {
+              name: "Path as id",
+              type: "string",
+              example: "/",
+            },
           },
-          properties: {},
           owners: ["alexander"],
         },
         cta: {
@@ -35,18 +48,26 @@ const plan: Measurement.Plan = {
                 { id: "title", required: true },
                 { id: "position", required: true },
               ],
-              sources: { web: { required: true } },
               trigger: { type: "visible" },
               type: "core",
             },
+            call: {
+              name: "CTA call",
+              description: "Click 'Schedule a call' button",
+              properties: [
+                { id: "title", required: true },
+                { id: "position", required: true },
+              ],
+              trigger: { type: "click" },
+              type: "core",
+            },
             start: {
               name: "CTA start",
               description: "Click 'get started' button",
               properties: [
                 { id: "title", required: true },
                 { id: "position", required: true },
               ],
-              sources: { web: { required: true } },
               trigger: { type: "click" },
               type: "core",
             },
@@ -57,7 +78,6 @@ const plan: Measurement.Plan = {
                 { id: "title", required: true },
                 { id: "position", required: true },
               ],
-              sources: { web: { required: true } },
               trigger: { type: "click" },
               type: "core",
             },
@@ -84,15 +104,13 @@ const plan: Measurement.Plan = {
               name: "Article impression",
               description: "",
               properties: [{ id: "id", required: true }],
-              sources: { web: { required: true } },
               trigger: { type: "visible" },
               type: "additional",
             },
             click: {
               name: "Article click",
               description: "",
               properties: [{ id: "id", required: true }],
-              sources: { web: { required: true } },
               trigger: { type: "click" },
               type: "additional",
             },
@@ -107,7 +125,6 @@ const plan: Measurement.Plan = {
                 { id: "author", required: true },
                 { id: "readingTime", required: true },
               ],
-              sources: { web: { required: true } },
               trigger: { type: "load" },
               type: "core",
             },
@@ -116,7 +133,6 @@ const plan: Measurement.Plan = {
               description:
                 "As soon as the last paragraph of an article is visible to the user",
               properties: [{ id: "id", required: true }],
-              sources: { web: { required: true } },
               trigger: { type: "visible" },
               type: "core",
             },

diff --git a/220916-code_talks/types.d.ts b/220916-code_talks/types.d.ts
@@ -40,16 +40,11 @@ export namespace Measurement {
     name: string;
     description: string;
     properties: Array<PropertyLink>;
-    sources: ActionSources;
     trigger: Trigger;
     type: ActionType;
   }
   type ActionType = "core" | "additional";
 
-  interface ActionSources {
-    [sourceId: string]: SourceLink;
-  }
-
   type ConsentList = Array<ConsentId>;
   type ConsentId = string;