Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to push a testing Docker image for amd64 #3

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

anuraaga
Copy link
Collaborator

This pushes a docker image for commits to a branch named testing. It is amd64-only for now since I could check it in my personal fork and will do arm64 after using the runner in this repo.

https://github.com/anuraaga/ollama/actions/runs/11043405886

Copy link
Collaborator

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work. maybe add a comment where my questions are, to clarify some things that are important about this.

build-container-image:
strategy:
matrix:
# TODO: Add arm64 runner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a separate runner because we need to generate and compile cpp code, that's the reason, right? (can't cross-compile)

on:
push:
branches:
- testing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the branch with patches applied right? this workflow isn't picking patches?

@anuraaga
Copy link
Collaborator Author

Sure, added some comments

@anuraaga anuraaga merged commit 34d6cf7 into elastic:main Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants