Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftr] Speed up FTR code owner check #205093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dolaru
Copy link
Member

@dolaru dolaru commented Dec 23, 2024

Summary

Switch to one matcher w/ all code owner patterns rather than separate matchers for each code owner pattern. Reduces the run time of scripts/check_ftr_code_owners.js by ~10x.

Before

▶ node scripts/check_ftr_code_owners.js
 info Reading CODEOWNERS file
 info Checking ownership for 8653 test files (this will take a while)
 info Ownership check complete (took 18.89 s)
 succ All test files have a code owner. 🥳

After

▶ node scripts/check_ftr_code_owners.js
 info Checked 8653 test files in 1.59s
 succ All test files have a code owner 🥳

Switch to one matcher w/ all code owner patterns rather than separate matchers for each code owner pattern. Reduces the run time of `scripts/check_ftr_code_owners.js` by 10x.
@dolaru dolaru self-assigned this Dec 23, 2024
@dolaru dolaru requested review from a team as code owners December 23, 2024 14:45
@dolaru dolaru added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Dec 23, 2024
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-test/index.ts

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / EQL Tab rendering should render the timeline table
  • [job] [logs] FTR Configs #73 / serverless search UI Serverless Inference Management UI delete action "before each" hook for "deletes modal successfully with usage"

Metrics [docs]

✅ unchanged

cc @dolaru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants