Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ResponseOps][Alerts] Fix muted alerts query using wrong filter (#204182) #205090

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Open

[8.x] [ResponseOps][Alerts] Fix muted alerts query using wrong filter (#204182) #205090

wants to merge 1 commit into from
+150 −2

Conversation

umbopepato
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@umbopepato
[ResponseOps][Alerts] Fix muted alerts query using wrong filter (elas…
13a7ef5 
…tic#204182)

## Summary

Reverts the `getMutedAlerts` filter to use rule ids instead of rule type
ids that caused the muted alerts state to be always empty.

## To verify

1. Create a rule that fire alerts
2. Navigate to `Stack management > Alerts`
3. Click on any alert actions menu (•••)
4. Toggle on and off the alert muted state and check that the action
updates accordingly and the slashed bell icon appears in the status cell
when muted

## Release note

Fix alert mute/unmute action

(cherry picked from commit d5af2e0)

# Conflicts:
#	x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/index.ts
@umbopepato umbopepato enabled auto-merge (squash) December 23, 2024 13:46
@umbopepato umbopepato mentioned this pull request Dec 23, 2024
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +111.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
@kbn/test-suites-xpack 727 728 +1

Total ESLint disabled count

id before after diff
@kbn/test-suites-xpack 752 753 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbopepato @elasticmachine