[ML] Replace useIsDarkTheme()
with EUI's colorMode
.
#205079
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
useIsDarkTheme()
hook with EUI'scolorMode
. Since this was the last hook in@kbn/ml-kibana-theme
left this removes the whole package too.Note that the hook subscribed to an observable and was able to update the theme in place. EUI's
colorMode
will only be updated after a page refresh. Since updating the Kibana advanced setting to enable dark mode requires a full page refresh too, I guess it's fair to remove this behavior in favor of this simplification.In the long run we should aim for getting rid of these checks altogether and rely on dark-mode-aware EUI tokens.
Checklist
release_note:breaking
label should be applied in these situations.