Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rubrik] Add managed volumes datastream #12173

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

devamanv
Copy link
Contributor

@devamanv devamanv commented Dec 20, 2024

Proposed commit message

The PR adds a new data stream to collect the metrics for Managed Volumes. Managed Volumes provide hosts with a backup target location on a Rubrik cluster. Following are the metrics collected:

Metric Description
Free Size Free capacity for the volume across all the channels, in bytes.
Num Channels Number of channels to divide the volume into. Each channel provides a unique share to write to.
Pending Snapshot Count Pending snapshots.
Snapshot Count Number of snapshots.
State State of managed volume.
Storage Utilization Used capacity for the volume across all the channels, in bytes.
Used Size Used capacity for the volume across all the channels, in bytes.
Volume Size Maximum capacity for the volume across all the channels, in bytes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image

@devamanv devamanv self-assigned this Dec 20, 2024
@devamanv devamanv added New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 20, 2024
@@ -0,0 +1,6 @@
# newer versions go on top
- version: "0.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw a previous comment about starting at 0.0.1, but incremening the minor version number for new datasets makes total sense, so i think keeping 0.1.0 -> 0.2.0 etc is good.

# newer versions go on top
- version: "0.2.0"
changes:
- description: Create an integration for Rubrik with Filesets datastream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filesets -> managed volumes

changes:
- description: Create an integration for Rubrik with Filesets datastream
type: enhancement
link: https://github.com/elastic/integrations/pull/12111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12111 -> 12173

@tommyers-elastic
Copy link
Contributor

sorry, i started reviewing this, but i saw it's got a load of unmodified code copied from the filesets PR. ping me when this is ready for review. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants