-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rubrik] Add managed volumes datastream #12173
base: main
Are you sure you want to change the base?
[rubrik] Add managed volumes datastream #12173
Conversation
…ntegration-initial
@@ -0,0 +1,6 @@ | |||
# newer versions go on top | |||
- version: "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i saw a previous comment about starting at 0.0.1
, but incremening the minor version number for new datasets makes total sense, so i think keeping 0.1.0
-> 0.2.0
etc is good.
# newer versions go on top | ||
- version: "0.2.0" | ||
changes: | ||
- description: Create an integration for Rubrik with Filesets datastream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filesets -> managed volumes
changes: | ||
- description: Create an integration for Rubrik with Filesets datastream | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/12111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12111 -> 12173
sorry, i started reviewing this, but i saw it's got a load of unmodified code copied from the filesets PR. ping me when this is ready for review. thanks! |
Proposed commit message
The PR adds a new data stream to collect the metrics for Managed Volumes. Managed Volumes provide hosts with a backup target location on a Rubrik cluster. Following are the metrics collected:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots