Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AWS Access Point ARN in compatible integrations #12154

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for AWS Access Point ARN in compatible integrations #12154

wants to merge 4 commits into from

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Add support for the new setting access_point_arn for the AWS S3 input added at elastic/beats#41495 for 8.16.2 and 8.17.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@chemamartinez chemamartinez self-assigned this Dec 18, 2024
@chemamartinez chemamartinez marked this pull request as ready for review December 18, 2024 17:18
@chemamartinez chemamartinez requested review from a team as code owners December 18, 2024 17:18
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh added Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Dec 18, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 18, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@chemamartinez
Copy link
Contributor Author

/test

@chemamartinez chemamartinez force-pushed the 11737-access_point_arn-awss3 branch from cba611c to 97eb11a Compare December 19, 2024 15:48
@chemamartinez chemamartinez force-pushed the 11737-access_point_arn-awss3 branch from 97eb11a to 88e5383 Compare December 19, 2024 17:07
@ShourieG
Copy link
Contributor

@chemamartinez, Mainly punctuation related changes and need to resolve conflicts. Otherwise looks LGTM to me.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

ShourieG
ShourieG approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/aws_logs/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/aws_logs/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/aws_logs/data_stream/generic/manifest.yml Outdated Show resolved Hide resolved
packages/aws_logs/data_stream/generic/manifest.yml Outdated Show resolved Hide resolved
packages/aws_logs/docs/README.md Outdated Show resolved Hide resolved
packages/aws_logs/docs/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@chemamartinez chemamartinez

Labels
enhancement New feature or request Integration:amazon_security_lake Amazon Security Lake Integration:aws_bedrock Amazon Bedrock Integration:aws_logs Custom AWS Logs Integration:aws AWS Integration:canva Canva Integration:carbon_black_cloud VMware Carbon Black Cloud Integration:cisco_umbrella Cisco Umbrella Integration:cloudflare_logpush Cloudflare Logpush Integration:f5_bigip F5 BIG-IP Integration:imperva_cloud_waf Imperva Cloud WAF Integration:jamf_protect Jamf Protect Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Integration:servicenow ServiceNow Integration:sublime_security Sublime Security Integration:symantec_endpoint_security Symantec Endpoint Security Integration:tanium Tanium Integration:trellix_edr_cloud Trellix EDR Cloud Team:obs-ds-hosted-services Label for the Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Access Point ARN option to integrations using AWS S3 input
4 participants
@chemamartinez @elasticmachine @ShourieG @andrewkroh