Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Asciidoc broken links (post migration) #12145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Asciidoc broken links (post migration) #12145

wants to merge 1 commit into from
+66 −66

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Dec 18, 2024 •
edited
Loading

@alaudazzi alaudazzi added documentation Improvements or additions to documentation Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Ecosystem Label for the Packages Ecosystem team [elastic/ecosystem] bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] labels Dec 18, 2024
@alaudazzi alaudazzi self-assigned this Dec 18, 2024
@alaudazzi alaudazzi requested review from a team as code owners December 18, 2024 06:59
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@alaudazzi alaudazzi requested review from rdner and mauri870 December 18, 2024 06:59
@elasticmachine
Copy link

elasticmachine commented Dec 18, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @alaudazzi

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

Package 1password 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
signin_attempts 9708.74 5076.14 -4632.6 (-47.72%) 💔

Package activemq 👍(2) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
queue 83333.33 62500 -20833.33 (-25%) 💔

Package apache_tomcat 👍(4) 💚(1) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
connection_pool 4504.5 2380.95 -2123.55 (-47.14%) 💔
localhost 24390.24 16129.03 -8261.21 (-33.87%) 💔
request 40000 27777.78 -12222.22 (-30.56%) 💔
session 20833.33 16666.67 -4166.66 (-20%) 💔

Package atlassian_confluence 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2525.25 1697.79 -827.46 (-32.77%) 💔

Package authentik 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
user 8771.93 6369.43 -2402.5 (-27.39%) 💔

Package azure_functions 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
functionapplogs 2074.69 1123.6 -951.09 (-45.84%) 💔

Package azure_network_watcher_nsg 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1623.38 1119.82 -503.56 (-31.02%) 💔

Package azure_network_watcher_vnet 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1436.78 1077.59 -359.19 (-25%) 💔

Package bbot 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asm_intel 6535.95 5464.48 -1071.47 (-16.39%) 💔

Package bitwarden 👍(1) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
group 33333.33 9803.92 -23529.41 (-70.59%) 💔
policy 6535.95 5319.15 -1216.8 (-18.62%) 💔

Package carbon_black_cloud 👍(2) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset_vulnerability_summary 13513.51 6097.56 -7415.95 (-54.88%) 💔
audit 22222.22 13888.89 -8333.33 (-37.5%) 💔

Package ceph 👍(3) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
osd_pool_stats 22222.22 18518.52 -3703.7 (-16.67%) 💔
pool_disk 25000 20408.16 -4591.84 (-18.37%) 💔

Package checkpoint_email 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 3039.51 2127.66 -911.85 (-30%) 💔

Package checkpoint_harmony_endpoint 👍(5) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
antibot 2976.19 2183.41 -792.78 (-26.64%) 💔
threatemulation 4184.1 3355.7 -828.4 (-19.8%) 💔

Package cisco_duo 👍(2) 💚(5) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
trust_monitor 14925.37 6944.44 -7980.93 (-53.47%) 💔

Package cisco_ios 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2118.64 1526.72 -591.92 (-27.94%) 💔

Package cisco_meraki 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3115.26 2493.77 -621.49 (-19.95%) 💔

Package citrix_waf 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1976.28 1577.29 -398.99 (-20.19%) 💔

Package cloudflare_logpush 👍(10) 💚(6) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
sinkhole_http 6756.76 5376.34 -1380.42 (-20.43%) 💔
workers_trace 10638.3 6993.01 -3645.29 (-34.27%) 💔

Package couchbase 👍(5) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
cbl_replication 12820.51 7936.51 -4884 (-38.1%) 💔
cluster 15625 10526.32 -5098.68 (-32.63%) 💔
database_stats 26315.79 16666.67 -9649.12 (-36.67%) 💔

Package couchdb 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
server 4716.98 3194.89 -1522.09 (-32.27%) 💔

Package crowdstrike 👍(3) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
falcon 13157.89 9615.38 -3542.51 (-26.92%) 💔

Package cybereason 👍(5) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malop_process 475.74 337.15 -138.59 (-29.13%) 💔

Package elasticsearch 👍(2) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
deprecation 5882.35 4464.29 -1418.06 (-24.11%) 💔
gc 4347.83 3412.97 -934.86 (-21.5%) 💔
server 6410.26 3891.05 -2519.21 (-39.3%) 💔

Package eset_protect 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device_task 7874.02 5154.64 -2719.38 (-34.54%) 💔

Package f5_bigip 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 513.87 403.71 -110.16 (-21.44%) 💔

Package first_epss 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerability 41666.67 21276.6 -20390.07 (-48.94%) 💔

Package fortinet_fortimail 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1028.81 785.55 -243.26 (-23.64%) 💔

Package github 👍(3) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 8695.65 7299.27 -1396.38 (-16.06%) 💔
dependabot 4184.1 3194.89 -989.21 (-23.64%) 💔

Package gitlab 👍(5) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
api 4347.83 3134.8 -1213.03 (-27.9%) 💔
auth 4716.98 3759.4 -957.58 (-20.3%) 💔

Package golang 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
expvar 3311.26 2754.82 -556.44 (-16.8%) 💔
heap 4385.96 3021.15 -1364.81 (-31.12%) 💔

Package hadoop 👍(0) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
application 5102.04 3816.79 -1285.25 (-25.19%) 💔
datanode 14925.37 9345.79 -5579.58 (-37.38%) 💔
namenode 9090.91 4950.5 -4140.41 (-45.54%) 💔

Package ibmmq 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
errorlog 2272.73 1672.24 -600.49 (-26.42%) 💔

Package jamf_protect 👍(4) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
web_traffic_events 8547.01 5747.13 -2799.88 (-32.76%) 💔

Package jumpcloud 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
events 3225.81 2732.24 -493.57 (-15.3%) 💔

Package keycloak 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2415.46 1620.75 -794.71 (-32.9%) 💔

Package lastpass 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
detailed_shared_folder 10204.08 7246.38 -2957.7 (-28.99%) 💔
user 5050.51 3571.43 -1479.08 (-29.29%) 💔

Package logstash 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 8196.72 5434.78 -2761.94 (-33.7%) 💔

Package m365_defender 👍(3) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 769.82 620.73 -149.09 (-19.37%) 💔

Package microsoft_dnsserver 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 14285.71 11235.96 -3049.75 (-21.35%) 💔

Package microsoft_sqlserver 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2053.39 1555.21 -498.18 (-24.26%) 💔
log 11235.96 7575.76 -3660.2 (-32.58%) 💔

Package mimecast 👍(2) 💚(3) 💔(6)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
ttp_ip_logs 16949.15 12820.51 -4128.64 (-24.36%) 💔
cloud_integrated_logs 5464.48 4504.5 -959.98 (-17.57%) 💔
message_release_logs 4504.5 3067.48 -1437.02 (-31.9%) 💔
siem_logs 3311.26 2227.17 -1084.09 (-32.74%) 💔
threat_intel_malware_customer 6289.31 5102.04 -1187.27 (-18.88%) 💔
threat_intel_malware_grid 9174.31 6172.84 -3001.47 (-32.72%) 💔

Package mongodb_atlas 👍(0) 💚(2) 💔(6)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alert 3367 2369.67 -997.33 (-29.62%) 💔
disk 14492.75 9174.31 -5318.44 (-36.7%) 💔
hardware 14925.37 10989.01 -3936.36 (-26.37%) 💔
mongod_audit 7633.59 6329.11 -1304.48 (-17.09%) 💔
organization 3597.12 2444.99 -1152.13 (-32.03%) 💔
project 3773.58 3012.05 -761.53 (-20.18%) 💔

Package netskope 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 1547.99 1237.62 -310.37 (-20.05%) 💔
events 2105.26 1618.12 -487.14 (-23.14%) 💔

Package nginx 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 4237.29 3174.6 -1062.69 (-25.08%) 💔

Package nginx_ingress_controller 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 2178.65 1718.21 -460.44 (-21.13%) 💔
error 18867.92 15625 -3242.92 (-17.19%) 💔

Package o365 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2403.85 1811.59 -592.26 (-24.64%) 💔

Package okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
system 1414.43 1164.14 -250.29 (-17.7%) 💔

Package oracle_weblogic 👍(0) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 15873.02 9259.26 -6613.76 (-41.67%) 💔
admin_server 23255.81 12820.51 -10435.3 (-44.87%) 💔
domain 23255.81 13888.89 -9366.92 (-40.28%) 💔
managed_server 29411.76 20408.16 -9003.6 (-30.61%) 💔

Package panw 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
panos 1305.48 1086.96 -218.52 (-16.74%) 💔

Package panw_cortex_xdr 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
incidents 8064.52 5747.13 -2317.39 (-28.74%) 💔

Package php_fpm 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
process 10204.08 6622.52 -3581.56 (-35.1%) 💔

Package pps 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 5235.6 3816.79 -1418.81 (-27.1%) 💔

Package prisma_access 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 549.15 466.64 -82.51 (-15.03%) 💔

Package proofpoint_tap 👍(2) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
clicks_blocked 1655.63 1379.31 -276.32 (-16.69%) 💔
message_delivered 3003 2053.39 -949.61 (-31.62%) 💔

Package qualys_vmdr 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
asset_host_detection 1072.96 820.34 -252.62 (-23.54%) 💔
knowledge_base 1751.31 1253.13 -498.18 (-28.45%) 💔

Package rapid7_insightvm 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerability 3968.25 2906.98 -1061.27 (-26.74%) 💔

Package santa 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3236.25 2173.91 -1062.34 (-32.83%) 💔

Package sentinel_one 👍(3) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
activity 2141.33 1642.04 -499.29 (-23.32%) 💔
threat 951.47 583.43 -368.04 (-38.68%) 💔

Package servicenow 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 3584.23 2985.07 -599.16 (-16.72%) 💔

Package slack 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2518.89 2008.03 -510.86 (-20.28%) 💔

Package spring_boot 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
http_trace 7812.5 6578.95 -1233.55 (-15.79%) 💔

Package squid 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 5747.13 4149.38 -1597.75 (-27.8%) 💔

Package stan 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 17543.86 11764.71 -5779.15 (-32.94%) 💔

Package system 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
auth 10989.01 8771.93 -2217.08 (-20.18%) 💔

Package tanium 👍(2) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
endpoint_config 8264.46 6756.76 -1507.7 (-18.24%) 💔

Package tetragon 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3846.15 2309.47 -1536.68 (-39.95%) 💔

Package ti_abusech 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malwarebazaar 4237.29 3496.5 -740.79 (-17.48%) 💔

Package ti_anomali 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
intelligence 7692.31 6535.95 -1156.36 (-15.03%) 💔

Package ti_eset 👍(2) 💚(3) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
botnet 8064.52 4329 -3735.52 (-46.32%) 💔
domains 12820.51 7518.8 -5301.71 (-41.35%) 💔

Package ti_mandiant_advantage 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat_intelligence 1589.83 1278.77 -311.06 (-19.57%) 💔

Package ti_rapid7_threat_command 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
ioc 2020.2 1650.17 -370.03 (-18.32%) 💔

Package ti_recordedfuture 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat 1788.91 1422.48 -366.43 (-20.48%) 💔

Package tines 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
time_saved 41666.67 31250 -10416.67 (-25%) 💔

Package traefik 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 1118.57 948.77 -169.8 (-15.18%) 💔

Package trellix_epo_cloud 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
device 2325.58 1801.8 -523.78 (-22.52%) 💔
group 23255.81 17543.86 -5711.95 (-24.56%) 💔

Package tychon 👍(14) 💚(0) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
externaldevicecontrol 2638.52 1876.17 -762.35 (-28.89%) 💔
harddrive 2604.17 1890.36 -713.81 (-27.41%) 💔
softwareinventory 2702.7 2141.33 -561.37 (-20.77%) 💔
systemcerts 1158.75 968.05 -190.7 (-16.46%) 💔
coams 2320.19 1968.5 -351.69 (-15.16%) 💔

Package websphere_application_server 👍(2) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
servlet 30303.03 17857.14 -12445.89 (-41.07%) 💔
session_manager 12820.51 10638.3 -2182.21 (-17.02%) 💔

Package windows 👍(6) 💚(0) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
applocker_packaged_app_deployment 10989.01 9259.26 -1729.75 (-15.74%) 💔
forwarded 1515.15 1161.44 -353.71 (-23.34%) 💔
windows_defender 15625 10000 -5625 (-36%) 💔

Package wiz 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
vulnerability 3236.25 2659.57 -576.68 (-17.82%) 💔

Package zeek 👍(30) 💚(8) 💔(5)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
capture_loss 18181.82 13513.51 -4668.31 (-25.68%) 💔
radius 18867.92 15151.52 -3716.4 (-19.7%) 💔
software 52631.58 37037.04 -15594.54 (-29.63%) 💔
ssh 37037.04 25641.03 -11396.01 (-30.77%) 💔
dhcp 16393.44 12048.19 -4345.25 (-26.51%) 💔

Package zoom 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
webhook 3367 2212.39 -1154.61 (-34.29%) 💔

Package zscaler_zia 👍(5) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 3984.06 3021.15 -962.91 (-24.17%) 💔
audit 3246.75 2169.2 -1077.55 (-33.19%) 💔

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

jsoriano
jsoriano reviewed Dec 18, 2024
View reviewed changes
packages/activemq/_dev/build/docs/README.md
@@ -39,7 +39,7 @@ You can use our hosted Elasticsearch Service on Elastic Cloud, which is recommen

## Setup

For step-by-step instructions on how to set up an integration, see the [Getting Started](https://www.elastic.co/guide/en/welcome-to-elastic/current/getting-started-observability.html) guide.
For step-by-step instructions on how to set up an integration, see the [Getting Started](https://www.elastic.co/guide/en/starting-with-the-elasticsearch-platform-and-its-solutions/current/getting-started-observability.html) guide.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alaudazzi do you need these packages to be released with this change? If that's the case you will also need to add a changelog entry. You can do that by running the following command on each package directory:

elastic-package changelog add --description "Update links to getting started docs" --next patch --link https://github.com/elastic/integrations/issues/12145 --type enhancement

chrisberkhout
chrisberkhout approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changelog/manifest updates as described by @jsoriano

@mjwolf
Copy link
Contributor

mjwolf commented Dec 18, 2024 •
edited
Loading

Hi @alaudazzi, You'll need to run elastic-package build in each of the integration package directories that are failing in CI, to regenerate the readme, and fix the test failures like this one (from the logs of the failing test jobs):

README.md is outdated. Rebuild the package with 'elastic-package build'

want | 0s
  | got | 0s
  | @@ -205,3 +205,3 @@
  | For step-by-step instructions on how to set up an integration, see the
  | -[Getting started](https://www.elastic.co/guide/en/welcome-to-elastic/current/getting-started-observability.html) guide.
  | +[Getting started](https://www.elastic.co/guide/en/starting-with-the-elasticsearch-platform-and-its-solutions/current/getting-started-observability.html) guide.

@andrewkroh andrewkroh added Integration:ess_billing Elasticsearch Service Billing Integration:ibmmq IBM MQ Integration:sysdig Sysdig Integration:microsoft_exchange_server Microsoft Exchange Server Integration:jamf_compliance_reporter Jamf Compliance Reporter Integration:teleport Teleport Integration:stormshield StormShield SNS Integration:apache_spark Apache Spark Integration:barracuda Barracuda Web Application Firewall Integration:system_audit System Audit Integration:zeronetworks Zero Networks Integration:first_epss First EPSS Integration:system System Integration:mysql MySQL Integration:php_fpm PHP-FPM Integration:falco Falco Integration:sysmon_linux Sysmon for Linux Integration:checkpoint Check Point Integration:airflow Airflow Integration:microsoft_sqlserver Microsoft SQL Server Integration:windows Windows Integration:spring_boot Spring Boot Integration:ti_eclecticiq EclecticIQ Integration:golang Golang Integration:citrix_adc Citrix ADC Integration:activemq ActiveMQ Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Dec 19, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

mauri870
mauri870 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the link changes, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano left review comments

@mauri870 mauri870 mauri870 approved these changes

@chrisberkhout chrisberkhout chrisberkhout approved these changes

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

At least 1 approving review is required to merge this pull request.

Assignees

@alaudazzi alaudazzi

Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation Integration:activemq ActiveMQ Integration:airflow Airflow Integration:apache_spark Apache Spark Integration:apache_tomcat Apache Tomcat Integration:barracuda Barracuda Web Application Firewall Integration:ceph Ceph Integration:checkpoint Check Point Integration:citrix_adc Citrix ADC Integration:elastic_package_registry Elastic Package Registry Integration:ess_billing Elasticsearch Service Billing Integration:falco Falco Integration:first_epss First EPSS Integration:golang Golang Integration:ibmmq IBM MQ Integration:iis IIS Integration:jamf_compliance_reporter Jamf Compliance Reporter Integration:jamf_protect Jamf Protect Integration:linux Linux Metrics Integration:microsoft_exchange_server Microsoft Exchange Server Integration:microsoft_sqlserver Microsoft SQL Server Integration:mysql MySQL Integration:nagios_xi Nagios XI Integration:nginx Nginx Integration:php_fpm PHP-FPM Integration:salesforce Salesforce Integration:spring_boot Spring Boot Integration:stormshield StormShield SNS Integration:sysdig Sysdig Integration:sysmon_linux Sysmon for Linux Integration:system_audit System Audit Integration:system System Integration:teleport Teleport Integration:ti_eclecticiq EclecticIQ Integration:ti_mandiant_advantage Mandiant Advantage Integration:traefik Traefik Integration:vsphere VMware vSphere Integration:windows Windows Integration:zeronetworks Zero Networks Team:Ecosystem Label for the Packages Ecosystem team [elastic/ecosystem] Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alaudazzi @elasticmachine @mjwolf @jsoriano @chrisberkhout @mauri870 @andrewkroh