-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add ES|QL doc structure #1403
Conversation
@ezimuel Ah, great! I'm sure it will take me longer than it would you, but if you like, I can put together a skeleton/notes or just take a crack at adapting it and you can expand...? Or happy to review and edit. |
@marciw I adapted the context for PHP with some examples. Let me know what do you think, thanks! |
This reverts commit adfac62.
@ezimuel I did a minor edit -- take a look when you can and feel free to veto my changes. Thanks again for writing this up! 🏆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds an
esql.asciidoc
file that sets up a basic structure for the ES|QL documentation. Based on @szabosteve's Java client docs PR (#789).This includes adding a folder structure for
helpers
instead of keeping the docs all on one page (but we can undo that).@ezimuel This needs expanding and tailoring for the PHP client (it's really just placeholder text from the Java client docs). All other feedback is welcome, especially because I'm still so new to Elastic and to the client docs.
Preview