Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize PHPStan configuration #1103

Closed
wants to merge 3 commits into from
Closed

Modernize PHPStan configuration #1103

wants to merge 3 commits into from

Conversation

szepeviktor
Copy link

The title says it all!

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

if (isset($params) === true && !empty($params)) {
if ($params !== []) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting to array only.
BTW empty internally does isset.

@szepeviktor
Copy link
Author

I feel I'm at the bottom of a rabbit-hole.

@ezimuel
Copy link
Contributor

ezimuel commented Jan 26, 2024

Closing this since it's outdated.

@ezimuel ezimuel closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants