-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List packages with benchmarks #1634
Draft
ruflin
wants to merge
1
commit into
elastic:main
Choose a base branch
from
ruflin:get-benchmark-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For someone to run benchmarks or ingest sample data it is currently not easy to find the packages that have templates for benchmarks available. This is a quick POC on how the list of integrations with benchmarks can be generated. Some ideas on how this could be used: * Add the list to the docs page around streaming data. Downside is that it needs to be manually (or automatically) updated from time to time * Add some command to elastic-package to list the packages with templates * Other ideas? The current output of the script looks as following: ``` python list_benchmark_packages.py Package: nginx * stubstatus-benchmark * error-benchmark Package: mysql * performance-benchmark Package: aws * sqs-benchmark * ec2metrics-benchmark * billing-benchmark * ec2logs-benchmark Package: kubernetes * container-benchmark * pod-benchmark
@jsoriano Do we have currently some other examples where users need to list X with elastic-package? It sounds a bit similar to search but is based on files. |
/test |
+1 on this solution |
@lalit-satapathy Move over to you as I think this is a nice way on how to show which packages have a benchmark. |
Open
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For someone to run benchmarks or ingest sample data it is currently not easy to find the packages that have templates for benchmarks available. This is a quick POC on how the list of integrations with benchmarks can be generated. Some ideas on how this could be used:
The current output of the script looks as following:
NOTE: I don't expect this PR to be merged, it is more how to generate something like this with and the code is to better explain the expectations.