Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple sample events #1423

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 30, 2023

Add a new samples setting to the system test configuration files, that can be optionally used to select specific documents for the collected sample files.

For example, to select a document that contains the 200 status code:

samples:
  - name: "200"
    condition:
      key: "http.response.status_code"
      value: "200"

When these samples are defined, the default sample_event.json is not collected. Instead, one document is collected for each defined sample, called sample_event_<name>.json, where <name> is the name in the config.

When multiple events are collected, all of them are rendered in the README when event is used.

A change is required in package-spec to support the multiple sample files.

Closes #773

@jsoriano jsoriano requested a review from a team August 30, 2023 22:09
@jsoriano jsoriano self-assigned this Aug 30, 2023
@jsoriano jsoriano force-pushed the multiple-sample-events branch from 739c861 to 14d25c0 Compare August 31, 2023 10:16
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @jsoriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple sample events
3 participants