Support exporting dashboards using the saved objects API #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
reviewed
Jul 14, 2023
internal/kibana/dashboards.go
Outdated
| logger.Debug("Export dashboards using the Kibana Saved Objects Export API") | ||
|
|
||
| exportRequest := exportSavedObjectsRequest{ | ||
| ExcludeExportDetails: true, |
There was a problem hiding this comment.
Would it be needed to set IncludeReferencesDeep to true, to get other references used in the dashboards like tags, searches, maps... ?
There was a problem hiding this comment.
Not sure, trying to add it.
internal/kibana/dashboards.go
Outdated
Comment on lines
38
to
42
| if sv.LessThan(semver.MustParse("8.8.0")) { | ||
| return c.exportWithDashboardsAPI(dashboardIDs) | ||
| } | ||
|
|
||
| return c.exportWithSavedObjectsAPI(dashboardIDs) |
💚 Build Succeeded
History
cc @jsoriano |
jsoriano
commented
Nov 24, 2023
| dashboards = append(dashboards, dashboard) | ||
| } | ||
|
|
||
| return dashboards, nil |
There was a problem hiding this comment.
To reuse the code introduced in #1565 if finally merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.