[8.x](backport #6276) Fix/5163 retry download upgrade verifiers #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix(5163): added context to the verify interface, updated relevant calls, added backoff roundtripper * fix(5163): added backoff roundtripper, added tests for asc file download * fix(5163): remove log * fix(5163): ran mage fmt * fix(5163): removed unused roundtripper * fix(5163): closing response body on unsuccesful responses * fix(5163): added changelog * fix(5163): added comment explaining the backoff function, added nolint comment * fix(5163): added logic to handle resetting request body in the retry roundtripper, added unit tests, updated comments * fix(5163): fixed linting errors * fix(5164): ran mage check (cherry picked from commit a5eb77b)
mergify
bot
requested review from
swiatekm and
pchila
and removed request for
a team
|
|
This pull request has not been merged yet. Could you please review and merge it @kaanyalti? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds backoff retry for verifier artifact requests
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Related issues
This is an automatic backport of pull request #6276 done by [Mergify](https://mergify.com).