Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include namespace inode numbers on process events #213

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Include namespace inode numbers on process events #213

merged 1 commit into from
Nov 20, 2024

Conversation

haesbaert
Copy link
Contributor

This diff adds the inode number of each namespace the process belongs to, to process events. Two namespaces were excluded: pid_for_children and time_for_children, see namespaces(7).

The pid namespace is a bit special as it's not in nsproxy, the user facing pid level is the last/deepest.

There was an inclusion of mnt ns, that is not used by beats or endpoint, I kept it but made it fetch from the new "path".

While here, add support for changing the compiler in gen_initramfs.sh by setting CC. While Fedora includes a ${arch}-linux-gnu-gcc, it doesn't include matching headers, so I can't really compile the tests locally.

This diff adds the inode number of each namespace the process belongs to, to
process events. Two namespaces were excluded: pid_for_children and
time_for_children, see namespaces(7).

The pid namespace is a bit special as it's not in nsproxy, the user facing pid
level is the last/deepest.

There was an inclusion of mnt ns, that is not used by beats or endpoint, I kept
it but made it fetch from the new "path".

While here, add support for changing the compiler in gen_initramfs.sh by setting
CC. While Fedora includes a ${arch}-linux-gnu-gcc, it doesn't include matching
headers, so I can't really compile the tests locally.
@haesbaert haesbaert requested a review from a team as a code owner November 19, 2024 10:50
Copy link
Contributor

@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stanek-michal stanek-michal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haesbaert haesbaert merged commit c16e7ef into main Nov 20, 2024
26 checks passed
@haesbaert haesbaert deleted the ns branch November 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants